Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • NetworkManager-openvpn NetworkManager-openvpn
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 44
    • Issues 44
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 4
    • Merge requests 4
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GNOMEGNOME
  • NetworkManager-openvpnNetworkManager-openvpn
  • Merge requests
  • !24

add support for explicit-exit-notify

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Katelyn Schiesser requested to merge slowbro/NetworkManager-openvpn:master into master Jul 03, 2020
  • Overview 11
  • Commits 1
  • Pipelines 4
  • Changes 1

From the manual..

–explicit-exit-notify [n] In UDP client mode or point-to-point mode, send server/peer an exit notification if tunnel is restarted or OpenVPN process is exited. In client mode, on exit/restart, this option will tell the server to immediately close its client instance object rather than waiting for a timeout.

I opted to not include the [n] as the manual was conflicted on what it actually means, and I have never seen explicit-exit-notify used with any args. It works/defaults to 1 with no args (.. --explicit-exit-notify ..) and effectively enables NM support for this option.

Adds UI option, import/export capability, nm-openvpn-service flag addition (only when proto != tcp), and a test for import/export.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master