GitLab

Use function pointers and populate them with the right functions for
each mode instead of interleaving confusing code everywhere.

Request secrets from NetworkManager when existing secrets are
insufficient and openvpn asks us for new ones.

https://bugzilla.gnome.org/show_bug.cgi?id=694307

https://bugzilla.gnome.org/show_bug.cgi?id=697740

Include the full path to the auth-dialog and properties library in the
.name file, like we already do for the main helper program.

https://bugzilla.gnome.org/show_bug.cgi?id=694768

Add a missing "\" so that the -I$(top_srcdir) is seen

The secret flags were getting ignored by the core, so even if the
password was marked NOT_REQUIRED, it would be asked for.

Only call g_type_init() on older glibs.

Add a missing #include (that presumably used to get accidentally
pulled in by something else).

Use -DGDK_VERSION_MIN_REQUIRED to avoid deprecation warnings on
GtkTable.

Basically that should have been added together with cb81bdce.
Note we still doesn't support multiple ports. So when exporting we get:
remote gatewayA 1234
remote gatewayB 1234
remote gatewayC 1234
On import, port from the last 'remote' line is taken.
remote gatewayA 1111
remote gatewayB 2222
remote gatewayC 3333
will result in using port 3333

Jiří Klimeš authored Nov 02, 2012 and Dan Williams committed Nov 07, 2012

We already support 'tls-remote', i.e. verifying server's X509/common name.
However, it make sense to support 'remote-cert-tls' as well.  It's another
important security option to protect against MITM attacks. For more info see
http://openvpn.net/index.php/open-source/documentation/howto.html#mitm

The argument is 'klass', not 'obj'.