Skip to content

auth dialog runs in timeout, delaying connection start by 20 seconds: don't wait for closed STDIN in wait_for_quit

Stefan Bühler requested to merge tik-stbuehler/NetworkManager-openconnect:fix-dialog-timeout into main

Hi,

when stdin is already EOF, wait_for_quit waits for the full 20 second timeout; only then will it exit, and only then will the connection backend actually get started.

I observe this on (multiple) debian testing systems (debian stable didn't have this issue); I think it is because of a change in NetworkManager nm_vpn_service_plugin_read_vpn_details: it now reads all available data and buffers it (and dropping the buffer when done), including the trailing QUIT\n\n message - so wait_for_quit can't find QUIT anymore. Accepting EOF as "QUIT" signal should be safe though.

cheers, Stefan

Merge request reports