By now nobody should be using this. Keep the code around for a little
longer just in case anybody still uses this.

The libnm-glib support also serves as an example how do we build two
different versions of the properties plugin. We'll soon be in a similar
situation with Gtk 4.0. (sigh.) Just don't drop it yet.

!11

https://bugzilla.redhat.com/show_bug.cgi?id=1633174
!10

Scan configuration file for all supported Libreswan properties.

https://bugzilla.redhat.com/show_bug.cgi?id=1633174

Put default esp and ike values for aggressive mode IKEv1 connections in
a shared define to be used throughout the code.
To the same also for ikelifetime and salifetime for IKEv1 connections.

During recent reworks to extend the configuration options to allow IKEv2
we used a dedicated boolean to track if XAUTH was enabled or not: the
plan was to extend support to IKEv1 connections without XAUTH.
This however never happened: moreover, IKEv1 is old and we will probably
want to focus on improving IKEv2 scenarios support more than IKEv1 ones
(XAUTH is a IKEv1 thing).

So, remove the XAUTH bool var and just assume that it is always enabled
on IKEv1 connections as we already do in all the other part of the code.

In the recent refactoring of the "Advanced" dialog the labelee relations
have been lost. Moreover, they have not been added to the brand new options.

Fixes: 792b7867

https://bugzilla.redhat.com/show_bug.cgi?id=1401860

!9

Jochen Jägers authored Sep 15, 2018 and Francesco Giudici committed Sep 17, 2018

Configuration of remoteid can also be necessary for connections
using IKEv1. remoteid_label and remoteid_entry are permanent visible now and
value is written to connection on "update_connection"

Make the advanced section a separate dialog, as we do with the other
VPN plugins. Add also all the supported options that were still missing
from the GUI.

allow to properly manage also GtkCheckButton widgets and GtkComboBox
ones that allow three-valued logic values ("yes", "no" and an optional
third one value, dependent on the property).
This will allow a more convenient way to init new widgets (we are going
to leverage this in the next commit).

refactor the code a bit, should not change behavior

When passing the left/right identifier to libreswan, always
prepend the id the '@' char but when:
- the id is an IP address
- the id already starts with '@'
- the id starts with '%'

#4
!6