GitLab

Include the file in the tarball so that the users don't have to
generate it for now. This works around an issue in the generator
tool [1], but also makes sure a good known file is used.

[1] gtk!4415

This utilizes the actions and the response callback to deal with the
dialog response and differentate between a positive and a negative
response.

It also switches to using the HeaderBar, because that's looks better and
works better with Gtk4.

Currently the advanced dialog always remembers what's set, regardless of
whether the user confirms it or dismisses it. This is not what users
expect and we'll fix it in the following commit.

Splitting off the widget setup and readback of values is done in
preparation for that.

This makes some useful things possible, such as running from a built source
tree or, in future, using a modified version of the file for Gtk4 version.

This does nothing, nm_vpn_plugin_utils_load_editor() is more than happy
with a relative path.

The labels are in a size group declared in the GtkBuilder file, which is
sufficient for good alignment.

Other VPN plugins do this and it makes it easier for maintainers to spot
potential problems.

...so that we don't accidentally use newer API.

We already depended on it (using g_close()) and nobody seems to have
complained.

We run this on an old-ish image and just want a tarball. We do run tests
later in the pipeline on fedora:latest.

This is only available in GLib 2.44, which we don't have.
Moreover, it's kinda useless here.

Matthew Smith authored Dec 30, 2021 and Lubomir Rintel committed Jan 18, 2022

See-also: https://wiki.debian.org/AppStream/Guidelines

!18

Anders Jonsson authored Sep 16, 2021 and Lubomir Rintel committed Oct 25, 2021

!16

Some options changed name in libreswan 4. Parse the version in the
'ipsec' output and use the appropriate options. Note that now both the
old and new options are accepted in the connection.

#6