GitLab

Change the order of the gtk objects specification in the xml file
to match the order in which they appear in the user interface:
basically order by top_attach/left_attach. No value is changed.

In the meanwhile, change label ids to something meaningful.

https://bugzilla.redhat.com/show_bug.cgi?id=1401860

!1

The pipeline begins with "build" stage doing a distcheck on Fedora 28
(which is still known to ship libnm-glib) and outputting a tarball
artifact.

The output is then used in the "test" stage.

In future, builds on some older platforms, CentOS and Ubuntu and clang
builds would be nice. Not implemented at this point, but it should be
straightforward enough.

Maybe a build with a Git snapshot of NetworkManager and/or
network-manager-applet would be useful at some point, but that's not
implemented either.

It's not necessarily present among the packages in a minimal
installation (such as Fedora's docker image). Worse even, libtool just
ends up not linking to some .la libraries.

Don't assume it's there.

It's a not necessarily present among the packages in a minimal
installation (such as Fedora's docker image). Worse even, configure just
ends up passing wrong linker flags on some architectures, without a word
of complain.

Don't assume it's there.

Autoconf installs it on autogen.

We're a compliant project and want automake to ensure we have NEWS,
INSTALL, etc. in the distribution.

We just need to disable portability warnings for the $(filter-out) GNU
make extension.

Based on the AppData.

Erik Andersson authored Oct 16, 2017 and Lubomir Rintel committed Oct 31, 2017

* Phase1 Lifetime - specifies ikelifetime=
* Phase2 Lifetime - specifies salifetime=
* Remote Network - specifies rightsubnet=

ikelifetime defaults to 24h, salifetime defaults to 24h
and rightsubnet defaults to 0.0.0.0/0 (the defaults
prior this commit).

https://github.com/NetworkManager/network-manager-libreswan/pull/1

Adjust the comments to the form that satisfy -Wimplicit-fallthrough in
GCC 7.2.

From the Red Hat translators.

https://bugzilla.redhat.com/show_bug.cgi?id=1383163