!23

Include the file in the tarball so that the users don't have to
generate it for now. This works around an issue in the generator
tool [1], but also makes sure a good known file is used.

[1] gtk!4415

...and do that in the GtkBuilder file.

  (process:1285020): GLib-GObject-WARNING **: 15:01:43.281: invalid (NULL) pointer instance

  Thread 1 "run-vpn-gtk4" received signal SIGTRAP, Trace/breakpoint trap.
  g_logv (log_domain=0x7ffff71b5012 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, format=<optimized out>, args=<optimized out>) at ../glib/gmessages.c:1417
  1417		  g_private_set (&g_log_depth, GUINT_TO_POINTER (depth));
  (gdb) bt
  #0  g_logv (log_domain=0x7ffff71b5012 "GLib-GObject", log_level=G_LOG_LEVEL_WARNING, format=<optimized out>, args=<optimized out>) at ../glib/gmessages.c:1417
  #1  0x00007ffff7090773 in g_log (log_domain=log_domain@entry=0x7ffff71b5012 "GLib-GObject", log_level=log_level@entry=G_LOG_LEVEL_WARNING, format=<optimized out>) at ../glib/gmessages.c:1455
  #2  0x00007ffff71ae8ea in g_type_check_instance (type_instance=<optimized out>) at ../gobject/gtype.c:4208
  #3  0x00007ffff71a1c58 in g_signal_handlers_disconnect_matched
      (instance=0x0, mask=mask@entry=(G_SIGNAL_MATCH_FUNC | G_SIGNAL_MATCH_DATA), signal_id=signal_id@entry=0, detail=detail@entry=0, closure=closure@entry=0x0, func=func@entry=0x7fffe42ebcb0 <password_storage_changed_cb>, data=0x5aba20) at ../gobject/gsignal.c:3022
  #4  0x00007fffe42ebac3 in dispose (object=0x5aba20 [FortisslvpnEditor]) at properties/nm-fortisslvpn-editor.c:529
  #5  0x00007ffff7197b14 in g_object_unref (_object=<optimized out>) at ../gobject/gobject.c:3549
  #6  g_object_unref (_object=0x5aba20) at ../gobject/gobject.c:3479
  #7  0x00007fffe42ec87b in nm_fortisslvpn_editor_new (connection=0x5ad260, error=0x7fffffffd9b8) at properties/nm-fortisslvpn-editor.c:494
  #8  0x00007fffe4d3a545 in nm_vpn_plugin_utils_load_editor
      (module_name=0x7fffe4d3b418 "libnm-gtk4-vpn-plugin-fortisslvpn-editor.so", factory_name=factory_name@entry=0x7fffe4d3b448 "nm_vpn_editor_factory_fortisslvpn", editor_factory=editor_factory@entry=0x7fffe4d3a890 <_call_editor_factory>, editor_plugin=editor_plugin@entry=0x597b60, connection=connection@entry=0x5ad260, user_data=user_data@entry=0x0, error=0x7fffffffd9b8) at shared/nm-utils/nm-vpn-plugin-utils.c:134
  #9  0x00007fffe4d3ac39 in get_editor (iface=0x597b60, connection=0x5ad260, error=0x7fffffffd9b8) at properties/nm-fortisslvpn-editor-plugin.c:103
  #10 0x0000000000401305 in main (argc=<optimized out>, argv=<optimized out>) at src/tests/run-vpn.c:65
  (gdb)

We run this on an old-ish image and just want a tarball. We do run tests
later in the pipeline on fedora:latest.

Local installation should override distro-provided. Also; there's no
point in looking into /bin: openfortivpn has no business being there and
on modern systems /bin is a symlink to /usr/bin anyways.

#35

Dimitrios Apostolou authored Nov 24, 2020 and Lubomir Rintel committed Feb 14, 2021

The related code was removed in 9dbb1c8a.

!22

Kamus Hadenes authored Mar 26, 2020 and Lubomir Rintel committed Feb 14, 2021

[lkundrak@v3.sk: tidied up a bit]

!14

Kamus Hadenes authored Mar 26, 2020 and Lubomir Rintel committed Feb 14, 2021

[lkundrak@v3.sk: split off "add support for cert-only authentication"
patch].

!14

tko authored Apr 04, 2020 and Beniamino Galvani committed Sep 14, 2020

#20
!15