Skip to content

Remove pps mdktmp

Govind Rajpurohit requested to merge curious_govind/papers:remove-pps_mdktmp into main

Title: Remove pps_mkdtemp from libdocument Public API

Summary: This PR removes the pps_mkdtemp function from the libdocument public API. The function was removed from pps-file-helpers.c, and its usage in papers_document::mkdtemp is replaced with a custom implementation in Rust, streamlining the codebase.

Changes Made:

  • Removed pps_mkdtemp function from pps-file-helpers.c.
  • Replaced calls to papers_document::mkdtemp with a new custom implementation in Rust.

Rationale:

pps_mkdtemp was not widely used and added unnecessary complexity to the public API. Replacing its usage with a Rust implementation improves maintainability and aligns with our ongoing effort to simplify the codebase.

Impact: No functional regressions expected. This change will not affect current users as pps_mkdtemp was rarely used, but they should note that it is now removed from the API.

Testing: All unit tests have passed successfully, ensuring that the removal of pps_mkdtemp has no unintended side effects. Closes #110 (closed)

Edited by Govind Rajpurohit

Merge request reports