1. 23 Oct, 2018 2 commits
  2. 19 Oct, 2018 9 commits
  3. 18 Oct, 2018 2 commits
  4. 17 Oct, 2018 6 commits
  5. 16 Oct, 2018 4 commits
  6. 15 Oct, 2018 5 commits
  7. 14 Oct, 2018 1 commit
  8. 12 Oct, 2018 4 commits
  9. 11 Oct, 2018 7 commits
    • Robert McQueen's avatar
      trivial: Rename shell initial_overview_load_done to initial_refresh_done · 63b6e524
      Robert McQueen authored
      As this is actually implemented by the loading page rather than the
      overview, name it more accurately/descriptively.
      63b6e524
    • Robert McQueen's avatar
      Have shell go to LOADING state by itself · 7958c57e
      Robert McQueen authored
      There isn't any reason to have the shell sit in the UNKNOWN state at setup and
      rely on the GsApplication to initialise it correctly. At the end of setup, have
      the shell start the initial refresh by itself.
      7958c57e
    • Robert McQueen's avatar
      Have shell advance from LOADING to OVERVIEW by itself · 5c8d0770
      Robert McQueen authored
      Have the shell leave the LOADING state by itself once the refresh is completed,
      avoiding confusing coupling between GsApplication and GsShell. This is done
      conditionally, after the "loaded" signal emission so that if GsApplication has
      a queued mode change (from --mode=...) this is respected and un-necessary mode
      changes are avoided.
      5c8d0770
    • Robert McQueen's avatar
      Remove broken/questionable shell mode change code · c330dc0f
      Robert McQueen authored
      The intention of this code is to finish the loading state early in the
      case that the mode is set to something other than the overview. However,
      it is broken because it was never updated after the loading page and
      loading state was separated out from the overview, so was checking for the
      callback on the wrong object.
      
      GsApplication relies on the "loaded" signal to defer any actions which
      need the initial refresh to have completed, so if this code actually did
      work, it would just undermine this logic anyway. The "loaded" signal
      will now only be emitted once the initial refresh has actually been
      finished (regardless of mode).
      c330dc0f
    • Robert McQueen's avatar
      Do not assign mode when window is closed · 1e3052fe
      Robert McQueen authored
      This could overwrite the loading state which the shell uses to prevent
      various actions which should be deferred until the initial refresh has
      finished.
      
      The GsApplication code that presents the application sets the mode to
      overview before showing the window, provided the loading is completed.
      1e3052fe
    • Robert McQueen's avatar
      When adding queued GApplication actions, don't clear the loading state · a18748ea
      Robert McQueen authored
      It's possible (although arguably, undesirable) for more than one GAction to be
      queued up before the shell has finished loading, so there is no reason to
      disconnect this callback when adding a deferred action. Leave it in place so
      GsApplication has one place to check whether the shell has finished the initial
      refresh or not.
      a18748ea
    • Robert McQueen's avatar
      Revert "trivial: Allow the application to change modes using activation" · 840509e6
      Robert McQueen authored
      This reverts commit ef15f51d as it caused a regression with the shell appearing
      in an undefined state when the window was reloaded. This function is only
      called in the default activation case, not the --mode=... or other specific
      GActions. These already correctly set their modes, so this one should always
      set overview if the initial loading is completed.
      840509e6