Commit 040e1e47 authored by Committed by Jan-Michael Brummer
Add code style rule regarding comparisons
Epiphany code is currently inconsistent as to whether we should explicitly compare pointers against NULL. Very recently, I started writing explicit comparisons everywhere, after learning that this is now encouraged by the GLib maintainers. However, I've started having second thoughts. It's verbose, for one. Also, the C++ community is working on style guidelines to discourage this: http://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es87-dont-add-redundant--or--to-conditions They make sense to me. We already have a similar rule in WebKit, except WebKit also enforces this for integer comparisons against zero. I don't like that. Let's follow the C++ core guidelines advise instead.
Showing with 4 additions and 0 deletions