1. 01 Jun, 2004 7 commits
    • Daniel Elstner's avatar
      :load_file_with_fallback): Get the UTF-8 encoded basename from the · 3a7bba4f
      Daniel Elstner authored
      * src/filetree.cc (FileTree::load_file_with_fallback): Get the
      UTF-8 encoded basename from the filename column of the tree model
      instead of stripping and converting fileinfo->fullname all over
      again.
      3a7bba4f
    • Daniel Elstner's avatar
      Move the assignment of 'false' to fileinfo->load_failed to the very end of · edf9db78
      Daniel Elstner authored
      * src/fileio.cc (load_file): Move the assignment of 'false' to
      fileinfo->load_failed to the very end of the function, because
      there is a tiny chance that one of the other assignments throws
      an exception.
      edf9db78
    • Daniel Elstner's avatar
      :find_increment_file_count): There is no need for the reverse_iterator · 231b4cb1
      Daniel Elstner authored
      * src/filetree.cc (FileTree::find_increment_file_count): There
      is no need for the reverse_iterator abstraction here -- just use
      plain iterators and decrement them.
      231b4cb1
    • Daniel Elstner's avatar
      :prev_match_file): As it turns out keeping track of the parent iterator · 42393d3d
      Daniel Elstner authored
      * src/filetree.cc (FileTree::prev_match_file): As it turns out
      keeping track of the parent iterator does have some merit.  While
      there was nothing wrong with the previous change, I discovered
      that the parent's children can be indexed in order to obtain an
      iterator pointing to the previous row.  At least for deep trees
      this is likely to be faster than resolving the whole path via
      Gtk::TreeModel::get_iter().
      42393d3d
    • Daniel Elstner's avatar
      :prev_match_file): There is no need to keep track of the parent iterator; · 2a02038b
      Daniel Elstner authored
      * src/filetree.cc (FileTree::prev_match_file): There is no need to
      keep track of the parent iterator; just use Gtk::TreePath::size()
      and TreePath::up().  Also use TreePath::push_back() instead of the
      deprecated TreePath::append_index().
      2a02038b
    • Daniel Elstner's avatar
      :find_matches_at_path_iter): Rename from find_matches_at_iter(): add a · ff3a7767
      Daniel Elstner authored
      * src/filetree.{cc,h} (FileTree::find_matches_at_path_iter):
      Rename from find_matches_at_iter(): add a path parameter and
      use it instead of obtaining the path from the iter argument.
      (FileTree::replace_matches_at_path_iter): Rename from
      replace_matches_at_iter(): add a path parameter and use it.
      (FileTree::find_matches): Use TreeModel::foreach() rather than
      foreach_iter() in order to gain a minor performance improvement
      by taking advantage of the supplied Gtk::TreePath.
      (FileTree::replace_all_matches): ditto.
      ff3a7767
    • Daniel Elstner's avatar
      :on_treestore_rows_reordered): New signal handler which updates the match · 03e0df4a
      Daniel Elstner authored
      * src/filetree.{cc,h} (FileTree::on_treestore_rows_reordered):
      New signal handler which updates the match boundaries defined by
      the [path_match_first_, path_match_last_] range.  Previously this
      has been handled in on_treestore_sort_column_changed(), which is
      unfortunately called before the actual sorting takes place.
      (FileTree::on_treestore_sort_column_changed): Remove.
      (FileTree::FileTree): Connect to signal_rows_reordered() instead
      of signal_sort_column_changed().
      03e0df4a
  2. 31 May, 2004 6 commits
  3. 30 May, 2004 9 commits
  4. 29 May, 2004 1 commit
  5. 28 May, 2004 9 commits
  6. 27 May, 2004 1 commit
    • Daniel Elstner's avatar
      On failure, don't fall back to the locale encoding anymore but straight to · 5052d823
      Daniel Elstner authored
      * src/stringutils.cc (filename_to_utf8_fallback): On failure,
      don't fall back to the locale encoding anymore but straight to
      plain ASCII.  Thus from now on, this function will never throw
      for errors of type ConvertError::ILLEGAL_SEQUENCE.  Also cover
      the new G_FILENAME_ENCODING variable in the warning message.
      
      * src/filetree.cc (FileTree::find_files): Remove the explicit
      handling of Glib::ConvertError.
      5052d823
  7. 26 May, 2004 2 commits
  8. 25 May, 2004 5 commits