Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • M metaolm
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Archive
  • metaolm
  • Issues
  • #2
Closed
Open
Issue created Sep 05, 2018 by Johannes Hayeß@jhaye🖤Maintainer

Make SignedDeviceKeys use Signatures, instead of just a HashMap

On writing the structs for serialising one-time-keys I used a different approach from the structs for the device keys:

I abstracted the HashMap for device signatures into its own Signatures struct.

This generally improves readability and also provides a generic approach to expressing signatures for these structs. As many JSON objects need to contain a "signatures" key, having such an approach would greatly reduce code duplication.

Efforts should be aligned with #1 (closed)

Assignee
Assign to
Time tracking