Commit 0f226983 authored by Cosimo Cecchi's avatar Cosimo Cecchi
Browse files

manager: don't clear the active log ref immediately on close

We were clearing the (possibly) last reference to a LogviewLog on close,
but did not also clear out the priv->active_log pointer.
Since also in case a log is closed we still want the active-changed
signal to be emitted with the old log pointer as parameter, don't clear
that ref and keep the internal state consistent. It will be cleared by
the next call to logview_manager_set_active_log().

https://bugzilla.gnome.org/show_bug.cgi?id=697790
parent 77a7d4e7
......@@ -411,8 +411,7 @@ logview_manager_close_active_log (LogviewManager *manager)
g_object_unref (file);
/* we own two refs to the active log; one is inside the hash table */
g_object_unref (active_log);
/* drop the hash table ref */
g_hash_table_remove (manager->priv->logs, log_uri);
g_free (log_uri);
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment