Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • gnome-games gnome-games
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Archive
  • gnome-gamesgnome-games
  • Merge requests
  • !422

WIP: Introduce hidden collections

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Neville Antony requested to merge nevilleantony98/gnome-games:wip/nevilleantony98/hiddencollections into master Aug 27, 2020
  • Overview 1
  • Commits 7
  • Pipelines 1
  • Changes 24

Just an experiment to try out hidden collections and maybe after refactoring game replacement this could continue.

Games can be correctly hidden and be brought back by "un-hiding" it in hidden collection subpage.

Problems with this MR:

  • I actually replace games in the game-model which will be slower and makes the game thumbnails flash
  • I currently don't ignore hidden games' thumbnails when generating collection thumbnails
  • Design for when all games are hidden. Right now the view is just empty instead of a page saying "Games maybe hidden" etc
  • Some critical errors related to getting style context and disconnecting signal handlers and both seems to be related to Game being null somehow

This fixes #71 (moved), #94 (moved) but as said it requires refactoring of the game replacement mechanism, after which this could be much easier to implement.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/nevilleantony98/hiddencollections