1. 02 Apr, 2014 1 commit
    • Andrés G. Aragoneses's avatar
      MetadataService: refactor SaveHttpStream() with 'using' pattern · 7dfb0b51
      Andrés G. Aragoneses authored
      This method was extremely convoluted because it was checking
      for nulls every time and calling Close() only in the proper
      situations.
      
      By employing the "using" pattern, we can achieve the same with
      less checks and less explicit calls to Close(), as this pattern
      checks for null before disposing, and the Dispose() methods of
      both HttpWebResponse and Stream call Close() underneath.
      
      The code becomes much more readable this way. (And this is also
      safer against resource leaks because the calls to Dispose()
      happen in a finally{} block.)
      7dfb0b51
  2. 31 Mar, 2014 2 commits
  3. 29 Mar, 2014 1 commit
  4. 28 Mar, 2014 1 commit
  5. 27 Mar, 2014 1 commit
    • Dmitriy Petukhov's avatar
      DatabaseSource: fix crash at Rating sync (bgo#727030) · a74b354c
      Dmitriy Petukhov authored
      OnTracksChanged() was iterating the PrimarySources collection,
      and on each iteration there could exist the possibility of making
      the ServiceManager.SourceManager.Sources collection change (and
      PrimarySources is a sub-set of this collection), for example:
      a new rating of 5 stars is set on a track, which makes the
      "Favorites" smart playlist appear (it could be invisible because
      of being empty before).
      
      Even if the super-set of a collection changes without making the
      sub-set change, its enumerator would see it "dirty" (out of sync)
      which would cause an exception, and make Banshee crash. The
      solution to this is make a copy of the PrimarySources sub-set
      before iterating it.
      Signed-off-by: Andrés G. Aragoneses's avatarAndrés G. Aragoneses <knocte@gmail.com>
      a74b354c
  6. 26 Mar, 2014 1 commit
  7. 25 Mar, 2014 1 commit
  8. 22 Mar, 2014 1 commit
  9. 21 Mar, 2014 1 commit
  10. 19 Mar, 2014 3 commits
  11. 18 Mar, 2014 8 commits
  12. 16 Mar, 2014 1 commit
  13. 15 Mar, 2014 3 commits
  14. 14 Mar, 2014 3 commits
  15. 13 Mar, 2014 2 commits
  16. 12 Mar, 2014 4 commits
    • Piotr Drąg's avatar
      Updated Polish translation · 1bf8b968
      Piotr Drąg authored
      1bf8b968
    • Andrés G. Aragoneses's avatar
      GStreamerSharp: bring back option to disable gapless · 9a04093c
      Andrés G. Aragoneses authored
      Our current unmanaged backend still has this option, so we should
      match the new managed backend to the same expectations. This brings
      back some code paths (and comments) from the unmanaged backend that
      were not present in the managed one (namely the use of the pending_*
      and next_track_pending fields).
      
      We plan to remove the Gapless setting soon (so it is always enabled
      by default and can't be changed), but we're not quite ready yet,
      given the number of bugs that are still affected by this setting (we
      have fixed some recently, which were backported to 2.6.2, but we're
      not there yet). We will track this progress in bgo#638943.
      
      Even though disabling gapless is an option that is not perfect
      (right now I'm experiencing an issue with volume being changed at
      transition), it is good to have it until our first 3.0 RC, so
      we can ask users to tell us if any given problems they
      experience with the new managed backend are gapless-related or
      not. We should concentrate in fixing gapless bugs rather than
      non-gapless issues that this brings.
      9a04093c
    • Daniel Mustieles García's avatar
      Updated Spanish translation · 433daac8
      Daniel Mustieles García authored
      433daac8
    • Marek Černocký's avatar
      Updated Czech translation · 62a68ecd
      Marek Černocký authored
      62a68ecd
  17. 11 Mar, 2014 1 commit
  18. 10 Mar, 2014 2 commits
  19. 03 Mar, 2014 1 commit
  20. 26 Feb, 2014 2 commits