1. 02 Apr, 2014 1 commit
    • Andrés G. Aragoneses's avatar
      HACKING: add missing rule about parameter names · 470a3f78
      Andrés G. Aragoneses authored
      There's a mixture of style in Banshee's codebase about param
      names. Sometimes they are written in the same way vars/fields
      are written (under_score notation), but sometimes they use
      camelCaseNotation. Lately I've come to realize that the latter
      is a bit more frequent, so we should write this down ASAP
      before we grow the mixed-style code indefinitely.
      470a3f78
  2. 07 Jan, 2014 1 commit
    • Andrés G. Aragoneses's avatar
      build: require NUnit 2.5 · 52166da1
      Andrés G. Aragoneses authored
      Previous commit [1] stated something which is not always true
      actually: although mono installs a mono-nunit.pc that contains
      the mono version (as opposed to NUnit version), some distros
      (like Debian/Ubuntu) have made that pc file be a symlink from
      /usr/lib/pkg-config/mono-nunit.pc to /usr/lib/pkg-config/nunit-pc.
      
      So the best thing is avoid this mess and only depend on NUnit,
      which BTW brings some nice API since version 2.5 (mono embeds
      version 2.4.8 [2]):
      
        Assert.That(actual, Is.EqualTo(expected));
      
      This API is more readable (maps better to English language) and has
      the added benefit of providing a way to never confuse again the
      parameter *actual* with *expected* that was so easy to switch by
      mistake on the older Assert.AreEqual(x,y) syntax.
      
      Some lines are added to the HACKING file about this as well, and
      the last test I wrote is converted to this syntax, as the first
      real sample to have in the codebase.
      
      [1] https://git.gnome.org/browse/banshee/commit/?id=3891ed1e5aaa7d06497525ab5bfc44110939a369
      [2] https://github.com/mono/mono/blob/master/mcs/nunit24/CommonAssemblyInfo.cs
      52166da1
  3. 09 Oct, 2013 1 commit
    • Andrés G. Aragoneses's avatar
      HACKING: add one more rule, unnoticed until now · 6e7e6724
      Andrés G. Aragoneses authored
      It turns out all the Banshee codebase has explicit accessors, even
      if `private` is normally the default when there is no accessor.
      
      This rule will deter people from using new MonoDevelop's SourceAnalysis
      facilities (or Resharper in the case of VS.NET) to cleanup code in an
      incorrect way.
      6e7e6724
  4. 25 Feb, 2013 1 commit
  5. 21 Jan, 2013 1 commit
  6. 14 Oct, 2012 1 commit
  7. 24 Aug, 2009 1 commit
  8. 26 Feb, 2008 1 commit
  9. 25 Jan, 2008 1 commit
  10. 15 Jan, 2008 1 commit
  11. 04 Dec, 2006 2 commits
  12. 17 Jul, 2006 2 commits
    • Aaron Bockover's avatar
      Updated · c84cc06f
      Aaron Bockover authored
      2006-07-17  Aaron Bockover  <abock@gnome.org>
      
          * HACKING: Updated
      c84cc06f
    • Aaron Bockover's avatar
      Updated · 442ac834
      Aaron Bockover authored
      2006-07-17  Aaron Bockover  <abock@gnome.org>
      
          * HACKING: Updated
      442ac834
  13. 31 Oct, 2005 1 commit
  14. 27 Aug, 2005 1 commit