GitLab

Fix RH #633169 again.
https://bugzilla.redhat.com/show_bug.cgi?id=633169

Extends the initial fix to cover auto-select in GtkEntry and
better report errors with time portion of the date/time.

Closes GNOME/evolution#681

Closes GNOME/evolution#729

Yi-Jyun Pan authored Nov 27, 2019 and Administrator committed Nov 27, 2019

(cherry picked from commit 06504139)

Closes GNOME/evolution#719

Closes GNOME/evolution#711

Closes GNOME/evolution#709

Closes GNOME/evolution#701

The e_simple_async_result_complete_idle() adds a reference to the passed-in
ESimpleAsyncResult instance and schedules an idle callback, where it is
also unreffed. Usual follow up action of the caller was to unref the result,
maybe in a dedicated thread. The race comes when the dedicated thread is
suspended before it removes its reference on the result and the idle callback
is processed before the thread is resumed. That can also mean to free
widgets, which are supposed to be freed only in the main/UI thread,
in the dedicated thread, causing crash or other issues. The fix is to
take the reference of the result, instead of adding its own and unreffing
it shortly after.

This is related to a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1770923

Closes GNOME/evolution#702

Closes GNOME/evolution#680

Closes GNOME/evolution#696

The JSCContext keeps exceptions between multiple calls, thus when one
call fails the consecutive calls would reuse the previous exception
until it is explicitly cleared, even though the following call succeeded
without any issue.

Timezone names with three slashes skipped only the first part, which could
make the too width for the time column.