GitLab

https://bugzilla.gnome.org/show_bug.cgi?id=689765

There's no need to check whether the 'parsers' GQueue is NULL since we
assert that it's non-NULL just a few lines above.

Use the existing AsyncContext struct instead of defining a new struct.

Use gtk_css_provider_load_from_data() instead.

Use gdk_device_get_position().

Call gtk_widget_style_get().  No need to get GtkStyle involved.

Documentation claims this step is unnecessary with GtkStyleContext,
and indeed the current gtk_style_attach() code does nothing at all.

Use GtkStyleContext-based "render" functions instead.

   gtk_paint_arrow()    --> gtk_render_arrow()
   gtk_paint_box()      --> gtk_render_background()
   gtk_paint_expander() --> gtk_render_expander()
   gtk_paint_flat_box() --> gtk_render_background()
   gtk_paint_shadow()   --> gtk_render_frame()
   gtk_paint_vline()    --> gtk_render_line()

Use gtk_widget_get_preferred_size() instead.

Use gdk_display_get_app_launch_context() instead.

Use gdk_device_grab() and gdk_device_ungrab() instead.

In some cases this requires stashing the grabbed device so it can be
ungrabbed outside of an GdkEvent handler.

GnomeCanvas will stash the GdkDevice and reuse it in the subsequent
gnome_canvas_item_ungrab() call.

Prefer dealing with GdkEvent pointers and using accessor functions like
gdk_event_get_button().

This is complicated by the fact that some GtkWidget method declarations
still use GdkEventButton pointers, and synthesizing button events pretty
much requires direct GdkEventButton access.  But GDK seems to be nudging
itself toward sealing the GdkEvent union.  Likely to happen in GDK4.

Mainly clean up signal handlers and leave method overrides alone for now.

Adding temporary printf() calls to aid in debugging is fine, but leaving
them in the code permanently is not useful, especially when maintenance
duties are passed on to others.

Adding temporary printf() calls to aid in debugging is fine, but leaving
them in the code permanently is not useful, especially when maintenance
duties are passed on to others.

Will be needed for grabs in response to button events.

Use gdk_window_get_device_position() instead.