1. 11 Feb, 2006 2 commits
    • Thomas Thurman's avatar
      Avoid a memory leak when checking which workspace(s) a window is on. Fixes · 7aebefad
      Thomas Thurman authored
      2006-02-10  Thomas Thurman <thomas thurman org uk>
      
      	Avoid a memory leak when checking which workspace(s) a window is
      	on.  Fixes #322059.
      
              * src/workspace.h (struct MetaWorkspace):
              * src/workspace.c (meta_workspace_new, meta_workspace_free):
      	added list_containing_self member to MetaWorkspace
      
              * src/window.c (meta_window_get_workspaces): use
      	window->workspace->list_containing_self instead of allocating (and
      	leaking) such a list on the fly.
      7aebefad
    • Thomas Thurman's avatar
      add messages to explain that warnings are harmless · 4b6a87ac
      Thomas Thurman authored
      2006-02-09  Thomas Thurman <thomas thurman org uk>
      
              * src/testboxes.c (test_regions_okay, test_clamping_to_region):
              add messages to explain that warnings are harmless
      4b6a87ac
  2. 07 Feb, 2006 1 commit
  3. 06 Feb, 2006 1 commit
  4. 05 Feb, 2006 1 commit
  5. 03 Feb, 2006 2 commits
  6. 02 Feb, 2006 1 commit
  7. 31 Jan, 2006 2 commits
  8. 30 Jan, 2006 4 commits
  9. 28 Jan, 2006 1 commit
  10. 27 Jan, 2006 1 commit
  11. 26 Jan, 2006 2 commits
  12. 24 Jan, 2006 2 commits
  13. 23 Jan, 2006 2 commits
  14. 22 Jan, 2006 3 commits
  15. 21 Jan, 2006 8 commits
  16. 20 Jan, 2006 7 commits
    • Elijah Newren's avatar
      Avoid flashing when closing a maximized window. Fixes #317254. · dcec1127
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	Avoid flashing when closing a maximized window.  Fixes #317254.
      
      	* src/window.c (unmaximize_window_before_freeing): new function
      	that just fixes the net_wm_state and sends a configure_notify,
      	(meta_window_free): use unmaximize_window_before_freeing() instead
      	of meta_window_unmaximize() to avoid flicker
      dcec1127
    • Elijah Newren's avatar
      Fix unitialized value problem when in raise-on-click mode. Søren, · 6f318f1a
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	Fix unitialized value problem when in raise-on-click mode.  Søren,
      	#327572.
      
      	* src/display.c (meta_display_check_threshold_reached): make
      	function be a no op if raise_on_click!=FALSE
      
      	* src/display.h (struct MetaDisplay): point out that
      	grab_initial_[xy] and grab_threshold_movement_reached are only for
      	raise_on_click==FALSE mode.
      6f318f1a
    • Elijah Newren's avatar
      Patch from Søren to fix some reading-from-free'd-data errors. #327575 · 5568f75c
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	Patch from Søren to fix some reading-from-free'd-data errors.
      	#327575
      
      	* src/edge-resistance.c (meta_display_cleanup_edges): store the
      	edges in a hash table so that we can still read their values
      	within the loop from the other array they are stored in, then free
      	them all at the end.
      5568f75c
    • Elijah Newren's avatar
      Fix various initialization and default issues, especially for · e2722959
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	Fix various initialization and default issues, especially for
      	--disable-gconf.  Make --disable-gconf actually work.  #326661.
      
      	* configure.in: Fix compilation with --disable-gconf
      	* src/metacity.schemas.in: Add a note that if any defaults are
      	  changed in this file, src/prefs.c may need to be updated to
      	  reflect the change
      	* src/prefs.c: set various static global vars to the right default
      	value, (meta_prefs_init): get the titlebar_font and current_theme
      	handled better when not using gconf, (struct MetaSimpleKeyMapping,
      	screen_string_bindings, window_string_bindings): helper vars to
      	allow some keybindings to work even without gconf,
      	(init_bindings): initialize bindings for the without-gconf case
      	too, (init_commands): make sure these are all NULL for the
      	non-gconf case so that we don't access random memory,
      	(init_workspace_names): just give these all a default name for the
      	non-gconf case,
      	(meta_prefs_change_workspace_name): actually change the name for
      	the non-gconf case too
      e2722959
    • Elijah Newren's avatar
      More careful error handling of values returned by GConf. Fixes #326615. · a556a733
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	More careful error handling of values returned by GConf.  Fixes
      	#326615.
      
      	* src/prefs.c (get_bool): new helper function, (meta_prefs_init):
      	use get_bool to handle the case of a gconf key not existing,
      	(update_cursor_size): sanity check for sane values
      a556a733
    • Elijah Newren's avatar
      Prevent rapidly repeated visual bells from hanging metacity. Fixes · af14d9d2
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	Prevent rapidly repeated visual bells from hanging metacity.
      	Fixes #322032.
      
      	* src/display.h (struct MetaDisplay): add a last_bell_time field,
      	(XSERVER_TIME_IS_BEFORE_ASSUMING_REAL_TIMESTAMPS macro,
      	XERVER_TIME_IS_BEFORE macro): add parentheses around usage of
      	macro parameter
      
      	* src/display.c (meta_display_open): initialize last_bell_time,
      	(event_callback): don't allow more than one bell per second
      af14d9d2
    • Elijah Newren's avatar
      Patch from Kjartan Maraas to fix a lot of tiny issues (unused variable · 32d4bd6b
      Elijah Newren authored
      2006-01-20  Elijah Newren  <newren gmail com>
      
      	* src/async-getprop.c:
      	* src/common.h:
      	* src/display.c:
      	* src/eggaccelerators.c:
      	* src/frames.c:
      	* src/gradient.c:
      	* src/iconcache.c:
      	* src/keybindings.c:
      	* src/metaaccellabel.c:
      	* src/place.c:
      	* src/prefs.c:
      	* src/preview-widget.c:
      	* src/screen.c:
      	* src/session.c:
      	* src/stack.c:
      	* src/tabpopup.c:
      	* src/theme-viewer.c:
      	* src/theme.c:
      	* src/window-props.c:
      	* src/window.c:
      	* src/workspace.c:
      	* src/tools/metacity-window-demo.c:
      	* src/wm-tester/test-gravity.c:
      	* src/wm-tester/test-resizing.c:
      	* src/wm-tester/test-size-hints.c:
      	Patch from Kjartan Maraas to fix a lot of tiny issues (unused
      	variable removal, making unused variables used again, correction
      	of types passed/declared for printf arguments, removal of unneeded
      	breaks and returns, dead code removal, dead code revival, renaming
      	to prevent shadowed variables, declaring unexported functions as
      	static) spotted by the intel compiler.  #321439
      32d4bd6b