1. 01 Oct, 2006 1 commit
  2. 18 Sep, 2006 1 commit
    • Elijah Newren's avatar
      Partial audit to fix timestamp usage. One step towards fixing #355180; see · 5c587726
      Elijah Newren authored
      2006-09-18  Elijah Newren  <newren gmail com>
      
      	Partial audit to fix timestamp usage.  One step towards fixing
      	#355180; see important comments in that bug.
      
      	* src/core.[ch] (meta_core_unshade, meta_core_shade):
      	* src/delete.c (meta_window_present_delete_dialog,
      	  delete_ping_timeout_func):
      	* src/display.[ch] (meta_display_open, meta_display_close,
      	  event_callback, meta_display_begin_grab_op,
      	  process_selection_clear, meta_display_unmanage_screen,
      	  meta_display_unmanage_windows_for_screen):
      	* src/frames.c (meta_frames_button_press_event):
      	* src/keybindings.c (handle_toggle_shade):
      	* src/main.c (main):
      	* src/screen.[ch] (update_num_workspaces, meta_screen_new,
      	  meta_screen_free, prefs_changed_callback):
      	* src/window.[ch] (meta_window_free, finish_minimize,
      	  implement_showing, meta_window_show, meta_window_maximize,
      	  meta_window_make_fullscreen_internal,
      	  meta_window_unmake_fullscreen, meta_window_shade,
      	  meta_window_unshade, window_activate, send_sync_request,
      	  meta_window_client_message, menu_callback,
      	  meta_window_update_keyboard_resize):
      	Remove usage of CurrentTime, meta_display_get_current_time() and
      	meta_display_get_current_time_roundtrip() where possible, or
      	document why it isn't possible, or at very least add a FIXME with
      	some explanation of my laziness and what needs to be done.
      5c587726
  3. 13 Sep, 2006 1 commit
    • Elijah Newren's avatar
      Fix issues on 64-bit machines with timestamps by using guint32 (like gtk+ · 3b047877
      Elijah Newren authored
      2006-09-13  Elijah Newren  <newren gmail com>
      
      	* src/common.h (MetaWindowMenuFunc):
      	* src/core.[ch] (meta_core_user_lower_and_unfocus,
      	  meta_core_user_focus, meta_core_show_window_menu,
      	  meta_core_begin_grab_op, meta_core_end_grab_op):
      	* src/delete.c (delete_ping_reply_func, delete_ping_timeout_func,
      	  meta_window_delete):
      	* src/display.[ch] (struct MetaDisplay, struct MetaPingData,
      	  sanity_check_timestamps, meta_display_open, event_callback,
      	  meta_spew_event, meta_display_set_grab_op_cursor,
      	  meta_display_begin_grab_op, meta_display_end_grab_op,
      	  meta_display_ping_timeout, meta_display_ping_window,
      	  process_pong_message, timestamp_too_old,
      	  meta_display_set_input_focus_window):
      	* src/keybindings.[ch] (grab_keyboard, ungrab_keyboard,
      	  meta_screen_grab_all_keys, meta_window_grab_all_keys,
      	  meta_window_ungrab_all_keys, error_on_generic_command,
      	  error_on_command, error_on_terminal_command):
      	* src/metacity-dialog.c (on_realize, warn_about_no_sm_support,
      	  error_about_command, main):
      	* src/screen.[ch] (struct _MetaScreen, meta_screen_new,
      	  meta_screen_show_desktop, meta_screen_apply_startup_properties):
      	* src/session.c (warn_about_lame_clients_and_finish_interact):
      	* src/window.[ch] (struct _MetaWindow,
      	  intervening_user_event_occurred, window_activate,
      	  meta_window_delete, meta_window_focus,
      	  meta_window_send_icccm_message, meta_window_client_message,
      	  menu_callback, meta_window_show_menu, struct EventScannerData,
      	  check_use_this_motion_notify, meta_window_begin_grab_op,
      	  meta_window_set_user_time):
      	* src/workspace.[ch] (focus_ancestor_or_mru_window,
      	  meta_workspace_activate_with_focus, meta_workspace_activate,
      	  meta_workspace_focus_default_window,
      	  focus_ancestor_or_mru_window):
      	Fix issues on 64-bit machines with timestamps by using guint32
      	(like gtk+ does) instead of Time.  #348305
      3b047877
  4. 19 Nov, 2005 1 commit
    • Elijah Newren's avatar
      Merge of all the changes on the constraints_experiments branch. This is · a7201d27
      Elijah Newren authored
      2005-11-18  Elijah Newren  <newren@gmail.com>
      
      	Merge of all the changes on the constraints_experiments branch.
      	This is just a summary, to get the full ChangeLog of those
      	changes (approx. 2000 lines):
      	  cvs -q -z3 update -Pd -r constraints_experiments
      	  cvs -q -z3 diff -pu -r CONSTRAINTS_EXPERIMENTS_BRANCHPOINT ChangeLog
      
      	Bugs fixed:
      	  unfiled - constraints.c is overly complicated[1]
      	  unfiled - constraints.c is not robust when all constraints
      	            cannot simultaneously be met (constraints need to be
      	            prioritized)
      	  unfiled - keep-titlebar-onscreen constraint is decoration
      	            unaware (since get_outermost_onscreen_positions()
      	            forgets to include decorations)
      	  unfiled - keyboard snap-moving and snap-resizing snap to hidden
      	            edges
      	   109553 - gravity w/ simultaneous move & resize doesn't work
      	   113601 - maximize vertical and horizontal should toggle and be
      	            co...
      a7201d27
  5. 04 Oct, 2004 1 commit
    • Elijah Newren's avatar
      Fix a variety of focus race conditions in all focus modes, or at least · 16b9aff4
      Elijah Newren authored
      2004-10-04  Elijah Newren  <newren@math.utah.edu>
      
      	Fix a variety of focus race conditions in all focus modes, or at
      	least make them harder to trigger (fixes #152000)
      
      	* src/core.[ch] (meta_core_user_lower_and_unfocus): add a
      	timestamp parameter; pass it along to
      	meta_workspace_focus_default_window
      
      	* src/display.[ch] (meta_display_get_current_time_roundtrip): new
      	function
      
      	* src/display.c (event_callback): pass a timestamp to the
      	meta_workspace_activate and meta_workspace_focus_default_window
      	function calls
      
      	* src/frames.c (meta_frames_button_press_event): pass a timestamp
      	to meta_core_user_lower_and_unfocus
      
      	* src/keybindings.c (handle_activate_workspace): pass a timestamp
      	to meta_workspace_activate, (process_workspace_switch_grab): pass
      	a timestamp to meta_workspace_focus_default_window and
      	meta_workspace_activate, (handle_toggle_desktop): pass a timestamp
      	to meta_workspace_focus_default_window,
      	(do_handle_move_to_workspace): pass a timestamp to
      	meta_workspace_activate_with_focus, (handle_workspace_switch):
      	meta_workspace_activate
      
      	* src/screen.c (meta_screen_new): pass a timestamp to
      	meta_workspace_activate
      
      	* src/window.c (meta_window_free): pass a timestamp to
      	meta_workspace_focus_default_window, (idle_calc_showing): don't
      	increment the focus sentinel here, (meta_window_minimize): pass a
      	timestamp to meta_workspace_focus_default_window,
      	(meta_window_client_message), pass a timestamp to
      	meta_workspace_focus_default_window
      
      	* src/workspace.h (meta_workspace_activate): add timestamp
      	parameter, (meta_workspace_activate_with_focus): add timestamp
      	parameter, (meta_workspace_focus_default_window): add timestamp
      	parameter
      
      	* src/workspace.c (meta_workspace_focus_mru_window): make this
      	function take a timestamp and use it for meta_window_focus or
      	XSetInputFocus, (meta_workspace_activate_with_focus): make this
      	function take a timestamp and pass it along to meta_window_focus
      	and meta_workspace_focus_default_window,
      	(meta_workspace_activate): make this function take a timestamp and
      	pass it to meta_workspace_activate_with_focus),
      	(meta_workspace_focus_default_window): make this function take a
      	timestamp, warn if its 0 but try to handle that case sanely, and
      	pass the timestamp on to meta_window_focus or
      	meta_workspace_focus_mru_window or XSetInputFocus
      16b9aff4
  6. 16 Sep, 2004 1 commit
    • Elijah Newren's avatar
      Patch from Ken Harris in #135786 to focus a new default window when · 63e1624b
      Elijah Newren authored
      2004-09-15  Elijah Newren  <newren@math.utah.edu>
      
      	Patch from Ken Harris in #135786 to focus a new default window
      	when lowering via middle-click on the frame.
      
      	* src/core.[hc], src/frames.c: rename meta_core_user_lower to
      	meta_core_user_lower_and_unfocus
      
      	* src/core.c (meta_core_user_lower_and_unfocus): if in
      	click-to-focus mode then also move the window to the back of the
      	mru list and focus the new default window for the active workspace
      63e1624b
  7. 24 Nov, 2003 1 commit
  8. 05 Jan, 2003 1 commit
    • Havoc Pennington's avatar
      handle the client having a shape mask, fixes #101806 · 6cfcc013
      Havoc Pennington authored
      2003-01-05  Havoc Pennington  <hp@pobox.com>
      
      	* src/frames.c (meta_frames_apply_shapes): handle
      	the client having a shape mask, fixes #101806
      
      	* src/core.c (meta_core_get_client_xwindow): new function
      
      	* src/frame.c, src/frame.h: keep a flag for whether we need to
      	update the frame shape
      
      	* src/window.c (meta_window_new): select for ShapeNotify
      
      	* src/display.h, src/display.c: actually query the shape
      	extension, instead of just using it all over the place.
      
      	* src/prefs.c (update_application_based): don't let people turn on
      	application_based, as it just causes funky bugs. We can reenable
      	the pref when/if it ever does something useful.
      6cfcc013
  9. 03 Nov, 2002 1 commit
    • Havoc Pennington's avatar
      new function, and remove workspace->name field, instead just get the name · 6a1abc74
      Havoc Pennington authored
      2002-11-03  Havoc Pennington  <hp@pobox.com>
      
      	* src/workspace.c (meta_workspace_get_name): new function,
      	and remove workspace->name field, instead just get the
      	name from prefs each time
      
      	* src/screen.c (meta_screen_update_workspace_names): update the
      	gconf key to persist workspace names here, instead of changing
      	the names we use
      
      	* src/util.c (topic_name): add META_DEBUG_PREFS
      
      	* src/prefs.c: change NUM_COMMANDS to 32 to allow more custom
      	commands, implement workspace names
      
      	* src/metacity.schemas.in: add workspace_names/name_NN gconf keys.
      6a1abc74
  10. 18 Oct, 2002 1 commit
  11. 16 Oct, 2002 1 commit
    • Havoc Pennington's avatar
      workspaces are all per-screen now, fix accordingly · 337812d5
      Havoc Pennington authored
      2002-10-16  Havoc Pennington  <hp@redhat.com>
      
      	* src/workspace.c: workspaces are all per-screen now, fix
      	accordingly
      
      	* src/core.c: fix multihead workspace stuff
      
      	* src/keybindings.c: multihead-rama
      
      	* src/screen.c (meta_screen_show_desktop): new functions to
      	replace display equivalents
      
      	* src/display.c (meta_display_get_workspace_by_screen_index): get
      	rid of this
      	(meta_display_get_workspace_by_index): get rid of this
      	(event_callback): handle _NET_SHOWING_DESKTOP message per-screen
      
      	* src/screen.c (meta_screen_get_workspace_by_index): new function
      
      	* src/screen.h (struct _MetaScreen): move workspace list, and
      	showing_desktop flag, to be per-screen
      
      	* src/window.c (window_query_root_pointer): return whether pointer
      	is on window's screen
      	(meta_window_handle_mouse_grab_op_event): don't use coordinates
      	from other screens when updating a window operation on the current
      	screen. I can't believe no one has reported this...
      337812d5
  12. 11 Oct, 2002 1 commit
  13. 27 Sep, 2002 1 commit
    • Havoc Pennington's avatar
      use MetaAccelLabel to display accelerators for the menu items · 47f67eb2
      Havoc Pennington authored
      2002-09-26  Havoc Pennington  <hp@pobox.com>
      
      	* src/menu.c (meta_window_menu_new): use MetaAccelLabel to display
      	accelerators for the menu items
      
      	* src/metaaccellabel.c: cut-and-paste GtkAccelLabel and port to
      	use virtual modifiers
      
      	* src/Makefile.am (metacity_SOURCES): add metaaccellabel.[hc]
      
      	* src/prefs.c (meta_prefs_get_window_binding): new function
      
      	* src/core.c (meta_core_get_menu_accelerator): new function
      47f67eb2
  14. 23 Jul, 2002 1 commit
  15. 05 May, 2002 1 commit
  16. 07 Feb, 2002 1 commit
    • Havoc Pennington's avatar
      disable custom log handler and fatal mask for now · 8ae714ee
      Havoc Pennington authored
      2002-02-06  Havoc Pennington  <hp@pobox.com>
      
      	* src/main.c (main): disable custom log handler and fatal mask for
      	now
      
      	* src/theme.c (meta_draw_op_list_draw):
      	Add META_DRAW_CLIP
      
      	* src/main.c: load theme, monitor current theme setting
      
      	* src/prefs.c: add "current theme" setting
      
      	* src/stack.c (meta_stack_free): don't try to free
      	last_root_children_stacked if it doesn't exist
      
      	* src/themewidget.c: pluggable GtkMisc subclass to use
      	for menu icons
      
      	* src/screen.c (meta_screen_manage_all_windows): fix
      	signed/unsigned warning
      
      	* src/frames.c: port to theme system
      	(meta_frames_style_set): chain up
      
      	* theme-format.txt: new file
      
      	* configure.in: add more compiler warnings
      
      	* src/theme.c: add various stuff needed to get theme parser
      	working. Remove the "spacer" concept from FrameLayout object.
      	Add draw op that references a draw op list.
      
      	* configure.in: require GTK 1.3.13
      
      	* src/Makefile.am: add theme-parser.[hc], implement loading a
      	theme
      
      	* src/theme.c: add "draw title" and "draw window icon" operations
      	(meta_draw_op_draw): put object_width/object_height in expression
      	environment before computing x/y. Handle out-of-memory when
      	creating pixbufs. Assorted other cleanups.
      8ae714ee
  17. 19 Jan, 2002 1 commit
    • Havoc Pennington's avatar
      give priority to keeping NW corner onscreen rather than SE, if we need to · 19d2e8c7
      Havoc Pennington authored
      2002-01-18  Havoc Pennington  <hp@pobox.com>
      
      	* src/window.c (constrain_position): give priority to keeping NW
      	corner onscreen rather than SE, if we need to shift the window
      	to fit inside constraints
      
      	* src/frames.c (meta_frames_get_geometry): don't depend on the
      	current window size
      
      	* src/theme.c: move geometry stuff in here, to be calculated as
      	part of the theme
      
      	* src/core.c (meta_core_get_client_size): new function to replace
      	meta_core_get_frame_size() so we don't have weird cycles
      	in the geometry calculation
      19d2e8c7
  18. 16 Sep, 2001 1 commit
  19. 30 Aug, 2001 1 commit
    • Havoc Pennington's avatar
      avoid focusing a window on tab popup popdown · 3e1c68b8
      Havoc Pennington authored
      2001-08-29  Havoc Pennington  <hp@pobox.com>
      
      	* src/display.c (event_callback): avoid focusing a window on tab
      	popup popdown
      
      	* src/screen.c (meta_screen_ensure_tab_popup): compute frame
      	outline size here
      3e1c68b8
  20. 29 Aug, 2001 1 commit
  21. 26 Jul, 2001 1 commit
    • rhp's avatar
      ... · b6e4c8bc
      rhp authored
      b6e4c8bc
  22. 11 Jul, 2001 1 commit
    • rhp's avatar
      ... · 71d3333d
      rhp authored
      71d3333d
  23. 30 Jun, 2001 1 commit
    • rhp's avatar
      ... · 43f807c5
      rhp authored
      43f807c5
  24. 23 Jun, 2001 1 commit
    • rhp's avatar
      ... · bf64e719
      rhp authored
      bf64e719
  25. 21 Jun, 2001 2 commits
    • rhp's avatar
      ... · 9e9ffdca
      rhp authored
      9e9ffdca
    • rhp's avatar
      ... · f845819c
      rhp authored
      f845819c
  26. 20 Jun, 2001 1 commit
    • rhp's avatar
      ... · 5fee6341
      rhp authored
      5fee6341
  27. 18 Jun, 2001 2 commits
    • rhp's avatar
      ... · 5fd26a27
      rhp authored
      5fd26a27
    • rhp's avatar
      ... · d090d9f2
      rhp authored
      d090d9f2
  28. 17 Jun, 2001 1 commit
    • rhp's avatar
      ... · 59513231
      rhp authored
      59513231
  29. 07 Jun, 2001 1 commit
    • rhp's avatar
      ... · 834452ca
      rhp authored
      834452ca
  30. 03 Jun, 2001 1 commit
    • rhp's avatar
      .. · c82a582a
      rhp authored
      c82a582a
  31. 31 May, 2001 1 commit
    • rhp's avatar
      ... · 1785975f
      rhp authored
      1785975f
  32. 30 May, 2001 1 commit
    • rhp's avatar
      ... · 287b6b15
      rhp authored
      287b6b15