1. 31 Jul, 2019 5 commits
  2. 30 Jul, 2019 2 commits
  3. 29 Jul, 2019 5 commits
  4. 28 Jul, 2019 8 commits
  5. 27 Jul, 2019 1 commit
  6. 26 Jul, 2019 1 commit
  7. 25 Jul, 2019 4 commits
  8. 24 Jul, 2019 6 commits
  9. 23 Jul, 2019 8 commits
    • Florian Müllner's avatar
      ci: Add eslint job to review stage · 3b5d13a0
      Florian Müllner authored
      We have now reduced the number of eslint errors enough to add it to
      the CI pipeline. There are still plenty of errors left though, so we
      cannot simply run eslint and fail on any errors. So instead, run it
      through a fancy script that:
       - generates an eslint report using the "regular" configuration
       - generates an eslint report using the "legacy" configuration
       - creates a combined report with errors common to both configurations
      When the pipeline is running for a branch or tag, the final report is
      printed out and the job succeeds (we know there are errors left);
      when the pipelne is running for a merge request, we fail if any errors
      are reported for the lines modified/added by the MR.
    • Florian Müllner's avatar
      ci: Merge 'source_check' stage into 'review' · ed37ba1d
      Florian Müllner authored
      GNOME apps use 'review' for the CI stage that generates and exports a
      flatpak bundle after a successful build, so they need some other name
      for anything that is checked before building; that's how we ended up
      with the somewhat awkward 'source_check' stage (inherited from Polari).
      But since the commit log check added a 'review' stage that runs pre-build,
      use that for all checks that are performed before the build stage.
    • Florian Müllner's avatar
      ci: Include git in extension-ci image · 8ea6fd19
      Florian Müllner authored
      It's useful for anything that does not want to limit itself to the
      checked out branch, like comparing source and target branch.
    • Florian Müllner's avatar
      perf: Shut up another eslint error · 93a461f3
      Florian Müllner authored
      The functions here are asynchronous to handle control back to the
      mainloop while waiting for an action to complete, not to run operations
      in parallel. That is, the race condition the rule is protecting against
      isn't an issue here, so disable the error.
    • Florian Müllner's avatar
      perf: Shut up an eslint error · fda7c9b0
      Florian Müllner authored
      The while(true) loop is intentional here and not a bug, so disable
      the corresponding eslint rule.
    • Florian Müllner's avatar
      style: Disable camelcase rule for GObject properties · 1e13f32c
      Florian Müllner authored
      For GObject properties, we follow the convention of all-lowercase,
      dash-separated names. Those translate to underscores in getters/setters,
      so exempt them from the newly added "camelcase" rule.
    • Florian Müllner's avatar
      cleanup: Mark globals used from other modules as exported · e3575595
      Florian Müllner authored
      eslint cannot figure out that those symbols are used from other modules
      via imports, so they trigger unused-variable errors. To fix, explicitly
      mark those symbols as exported.
    • Florian Müllner's avatar
      cleanup: Mark unused (but useful) variables as ignored · 71759a07
      Florian Müllner authored
      While we aren't using those destructured variables, they are still useful
      to document the meaning of those elements. We don't want eslint to keep
      warning about them though, so mark them accordingly.